Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoder: Add support for Axie Infinity's ERC721 Transfer/Approve events #494

Merged
merged 7 commits into from Nov 5, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Nov 5, 2019

Axie Infinity incorrectly implemented the ERC721 events Transfer and Approve, omitting the index on _tokenId. Since we've been seeing a lot of orders added to Mesh for this specific contract, we've decided to add support for decoding ERC721 events with this variant of indexes.

zeroex/orderwatch/decoder/event_decoder.go Outdated Show resolved Hide resolved
zeroex/orderwatch/decoder/event_decoder.go Outdated Show resolved Hide resolved
@fabioberger fabioberger force-pushed the feature/supportDecodingAxieInfinityEvents branch from 112fd83 to f17a518 Nov 5, 2019
@albrow albrow self-requested a review Nov 5, 2019
@albrow
albrow approved these changes Nov 5, 2019
@albrow albrow merged commit b1dbc6a into development Nov 5, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the feature/supportDecodingAxieInfinityEvents branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.