Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TypeScript config parameters lowercase #502

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@albrow
Copy link
Member

albrow commented Nov 6, 2019

The Config object in the TypeScript bindings was incorrectly using capital letters for some fields instead of lowercase letters. This bug meant that the fields were not passed through and interpreted correctly by the Go code.

@albrow albrow requested a review from fabioberger Nov 6, 2019
@albrow albrow merged commit a08b205 into development Nov 6, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the fix/typescript-config-lowercase branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.