Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upethereum/ratelimit: Fix bug in for timezones behind UTC #505
Conversation
This comment has been minimized.
This comment has been minimized.
@fabioberger I can manually confirm this fixes the bug, but ideally we should write a regression test to prevent this from popping up again. I can't figure out how to do that, and the existing tests always pass in my local timezone, regardless of time of day. Any ideas? |
… to UTC in rate limiter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
albrow commentedNov 7, 2019
The following error was occurring at certain times of day for timezones that are behind UTC:
To be more specific, the bug seems to occur whenever the current local time is before midnight, but the time in UTC is the next day after midnight. When Mesh enters this state, no Ethereum RPC requests are allowed and Mesh cannot really function effectively.