Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for pinned option in TypeScript RPC client #514

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@albrow
Copy link
Member

albrow commented Nov 8, 2019

This PR fixes a bug when trying to add orders via the TypeScript RPC client:

Error: Node error: {"code":-32602,"message":"invalid argument 1: json: cannot unmarshal bool into Go value of type rpc.AddOrdersOpts"}
@fabioberger fabioberger merged commit 0e77f9a into development Nov 8, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@fabioberger fabioberger deleted the fix/typescript-rpc-client-pinned-opt branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.