Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Upgrade BigNumber.js version used by Mesh TS Client to ~9.0.0 #527

Merged
merged 7 commits into from Nov 14, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Nov 14, 2019

@0x/mesh-rpc-client is a dependency to @0x/orderbook and @0x/asset-swapper and we have been asked by Augur to upgrade our BigNumber.js dependency in our tooling (0xProject/0x-monorepo#2331) -- and our version is quite old.

In order to be able to refactor the monorepo to the new BigNumber version, it must first be updated in @0x/mesh-rpc-client. That is what this PR does. We will eventually switch back to using @0x/utils after the 0x packages have been published.

@fabioberger fabioberger changed the base branch from master to development Nov 14, 2019
@fabioberger fabioberger force-pushed the refactor/bigNumberUpgrade branch from 9f7fa4b to c6c9eff Nov 14, 2019
@fabioberger fabioberger requested a review from albrow Nov 14, 2019
@fabioberger fabioberger changed the base branch from development to 0xV3 Nov 14, 2019
@fabioberger fabioberger force-pushed the refactor/bigNumberUpgrade branch from c0db23c to db8f8a0 Nov 14, 2019
CHANGELOG.md Outdated Show resolved Hide resolved
rpc/clients/typescript/src/types.ts Show resolved Hide resolved
@fabioberger fabioberger force-pushed the refactor/bigNumberUpgrade branch from 2ba2214 to 0d0240d Nov 14, 2019
@albrow
albrow approved these changes Nov 14, 2019
@fabioberger fabioberger merged commit 51159a4 into 0xV3 Nov 14, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@fabioberger fabioberger deleted the refactor/bigNumberUpgrade branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.