Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Fix bug of re-emitting receipt logs, re-sharing, re-adding duplicate orders #529

Merged
merged 2 commits into from Nov 14, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Nov 14, 2019

New behavior: If order isn't new, e.g., we've already stored it, we avoid adding it to OrderWatcher again, triggering a log event and sharing it with peers once more.

… to OrderWatcher again, triggering a log event and sharing it with peers once more
@fabioberger fabioberger changed the base branch from master to development Nov 14, 2019
@fabioberger fabioberger requested a review from albrow Nov 14, 2019
@albrow
albrow approved these changes Nov 14, 2019
@fabioberger fabioberger merged commit d56b2e5 into development Nov 14, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@fabioberger fabioberger deleted the fix/excessLogs branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.