Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default RPC port to 60557 #542

Merged
merged 3 commits into from Nov 19, 2019

Conversation

@albrow
Copy link
Member

albrow commented Nov 18, 2019

There is currently a discrepancy in the documentation regarding the default RPC port. See https://0x-org.gitbook.io/mesh/v/v6.0.1-beta/getting-started/deployment.

In part of the documentation we claim:

Ports 60557, 60558, and 60559 are the default ports used for the JSON RPC endpoint, communicating with peers over TCP, and communicating with peers over WebSockets, respectively.

However, later the documentation conflicts with this when the RPC_ADDR environment variable itself is documented:

// RPCAddr is the interface and port to use for the JSON-RPC API over
// WebSockets. By default, 0x Mesh will listen on localhost and will let the
// OS select a randomly available port.
RPCAddr string envvar:"RPC_ADDR" default:"localhost:0"

In version 6.0.1-beta, Mesh randomly selected an available port by default. So the second part of the docs was correct.

After thinking about this some more, I actually think it makes more sense to use 60557 as the default port, as we already suggest in the docker-compose.yml file for enabling telemetry. This PR updates the default RPC_ADDR to use port 60557 and also updates the relevant portions of our documentation so that everything is consistent.

@albrow albrow changed the title Set default RPC port to 60557. Set default RPC port to 60557 Nov 18, 2019
@albrow albrow requested a review from fabioberger Nov 18, 2019
Copy link
Contributor

fabioberger left a comment

Please add a CHANGELOG entry for this.

albrow added 3 commits Nov 18, 2019
@albrow albrow force-pushed the fix/default-rpc-port branch from 7bb2034 to b1f1cb4 Nov 19, 2019
@albrow albrow merged commit ac77927 into development Nov 19, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/drone/push Build is passing
Details
@albrow albrow deleted the fix/default-rpc-port branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.