Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle nil errors from rpcSub.Err #544

Merged
merged 2 commits into from Nov 19, 2019

Conversation

@albrow
Copy link
Member

albrow commented Nov 19, 2019

Based on feedback from Discord. We were seeing the following log:

{"err_null":null,"level":"error","msg":"rpcSub returned an error","myPeerID":"16Uiu2HAm6PCaDbQscruxnGCUWgpxvX4RXqAUk3fGZy7CACCZ4Qpj","time":"2019-11-19T01:12:04Z"}

It is apparently possible to receive a value of nil from the rpcSub.Err() channel. This PR updates our code to handle that edge case.

@albrow albrow requested a review from fabioberger Nov 19, 2019
albrow added 2 commits Nov 19, 2019
@albrow albrow force-pushed the fix/handle-nil-error-from-rpc-sub branch from c3baf21 to bcec2a4 Nov 19, 2019
@albrow albrow merged commit 48ff228 into development Nov 19, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the fix/handle-nil-error-from-rpc-sub branch Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.