Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always unsubscribe from order events in SetupOrderStream #552

Merged
merged 4 commits into from Nov 21, 2019

Conversation

@albrow
Copy link
Member

albrow commented Nov 21, 2019

Fixes a possible bug where failing to unsubscribe from the order events feed can cause Mesh to hang.

@albrow albrow requested a review from fabioberger Nov 21, 2019
albrow added 2 commits Nov 21, 2019
CHANGELOG.md Outdated Show resolved Hide resolved
Co-Authored-By: Fabio B <me@fabioberger.com>
@albrow albrow merged commit 3234099 into master Nov 21, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/drone/push Build is passing
Details
@albrow albrow deleted the fix/always-unsubscribe-order-feed branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.