Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null fee asset data in browser bindings #579

Merged
merged 2 commits into from Dec 12, 2019
Merged

Conversation

@albrow
Copy link
Member

albrow commented Dec 9, 2019

Previously, a null makerAssetFeeData or takerAssetFeeData was being encoded as an empty string, which is incorrect.

@albrow albrow requested a review from fabioberger Dec 9, 2019
@albrow albrow added the browser label Dec 9, 2019
@albrow albrow assigned fabioberger and unassigned jalextowle Dec 9, 2019
Copy link
Contributor

fabioberger left a comment

LGTM once a changelog entry is added.

@albrow albrow merged commit e881b7d into 0xV3 Dec 12, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/drone/push Build is passing
Details
@albrow albrow deleted the fix/null-fee-asset-data branch Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.