Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc,core: Add timestamp to GetOrders snapshots #591

Merged
merged 9 commits into from Dec 13, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Dec 13, 2019

Fixes: #567

…at point in time the orders snapshot was taken
@fabioberger fabioberger changed the title rpc,core: Add timestamp to snapshots and order events rpc,core: Add timestamp to GetOrders snapshots Dec 13, 2019
@fabioberger fabioberger marked this pull request as ready for review Dec 13, 2019
@fabioberger fabioberger requested a review from albrow Dec 13, 2019
@fabioberger fabioberger self-assigned this Dec 13, 2019
core/core.go Show resolved Hide resolved
rpc/client_server_test.go Outdated Show resolved Hide resolved
rpc/clients/typescript/src/ws_client.ts Show resolved Hide resolved
rpc/clients/typescript/src/ws_client.ts Show resolved Hide resolved
@albrow
albrow approved these changes Dec 13, 2019
Copy link
Member

albrow left a comment

Just want to add a small doc comment then LGTM!

rpc/clients/typescript/src/types.ts Show resolved Hide resolved
@fabioberger fabioberger merged commit d5be2b8 into development Dec 13, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/drone/push Build is passing
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.