Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zeroex,rpc,browser: Add Timestamp to OrderEvents #602

Merged
merged 4 commits into from Dec 19, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Dec 19, 2019

Fixes: #557

For Mesh-specific events, we use the current UTC time. For on-chain state triggered events, we use the block height at which the order was re-validated.

browser/ts/index.ts Outdated Show resolved Hide resolved
@albrow

This comment has been minimized.

Copy link
Member

albrow commented Dec 19, 2019

I requested a small change and also want to make sure CI passes.

@fabioberger fabioberger force-pushed the feature/orderEventTimestamps branch from e06dbc1 to 3d45e13 Dec 19, 2019
@albrow
albrow approved these changes Dec 19, 2019
@fabioberger fabioberger self-assigned this Dec 19, 2019
@fabioberger fabioberger merged commit 960072d into development Dec 19, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/drone/push Build is passing
Details
@fabioberger fabioberger deleted the feature/orderEventTimestamps branch Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.