Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: Add RPC request timeout to default wsOpts #603

Merged
merged 4 commits into from Dec 19, 2019

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Dec 19, 2019

Fixes: #600

Currently if one instantiates a WSClient without supplying a custom wsOpts param, the client defaults to not having a timeout length on the RPC requests it sends. This is problematic, because during network disruptions, it is possible for the client to miss a response and hang forever. Because of this, we are changing the default to include a 30sec timeout on all non-subscription RPC requests.

fabioberger added 2 commits Dec 19, 2019
…om hanging if a network disruption causes it to miss responses
@fabioberger fabioberger requested a review from albrow Dec 19, 2019
@fabioberger fabioberger changed the base branch from master to development Dec 19, 2019
@fabioberger fabioberger self-assigned this Dec 19, 2019
@albrow
albrow approved these changes Dec 19, 2019
@fabioberger fabioberger merged commit fa106b9 into development Dec 19, 2019
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/drone/push Build is passing
Details
@fabioberger fabioberger deleted the fi/addDefaultTimeout branch Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.