Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase max order size and create separate max message size #631

Merged
merged 5 commits into from Jan 10, 2020

Conversation

@albrow
Copy link
Member

albrow commented Jan 9, 2020

Fixes #615.

This PR increases the maximum order size to 16k bytes. It also introduces a separate limit called MaxMessageSizeInBytes and a corresponding error ErrMaxMessageSize. Previously we were conflating these two limits, but they should technically be different.

albrow added 4 commits Jan 9, 2020
@albrow

This comment has been minimized.

Copy link
Member Author

albrow commented Jan 9, 2020

@jalextowle can you double check that this order size will not exceed the gas cost limits on mainnet?

…size
@albrow albrow merged commit 2027ebb into development Jan 10, 2020
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/drone/push Build is passing
Details
@albrow albrow deleted the split-max-order-size-and-max-message-size branch Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.