Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core,ethereum: Allow testnet contract addressses override #640

Merged
merged 6 commits into from Jan 13, 2020

Conversation

@fabioberger
Copy link
Contributor

fabioberger commented Jan 13, 2020

Several developers have been slowed down by having to wait until a smart contract fix be officially included in Mesh. This PR allows them to point their Mesh node to the fixed smart contract on testnets while still guarding mainnet contracts from being swapped out.

@fabioberger fabioberger requested a review from albrow Jan 13, 2020
@fabioberger fabioberger self-assigned this Jan 13, 2020
ethereum/contract_addresses.go Outdated Show resolved Hide resolved
@fabioberger fabioberger force-pushed the feature/overrideTestnets branch from ae75e83 to 2d67fcb Jan 13, 2020
@albrow albrow self-requested a review Jan 13, 2020
@albrow
albrow approved these changes Jan 13, 2020
@fabioberger fabioberger merged commit ddab621 into master Jan 13, 2020
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/drone/push Build is passing
Details
@fabioberger fabioberger deleted the feature/overrideTestnets branch Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.