Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convertConfig Tests #703

Merged
merged 6 commits into from Feb 12, 2020
Merged

convertConfig Tests #703

merged 6 commits into from Feb 12, 2020

Conversation

@jalextowle
Copy link
Contributor

jalextowle commented Feb 5, 2020

Added tests for the convertConfig function that use the new framework.

@jalextowle jalextowle force-pushed the test/convert-config-test branch from 5501160 to e81d52b Feb 5, 2020
@jalextowle jalextowle force-pushed the test/convert-config-test branch from fc661e9 to 59bd9d9 Feb 5, 2020
@@ -2,6 +2,9 @@ const path = require('path');

module.exports = {
entry: './conversion-tests/conversion_test.ts',
node: {
fs: 'empty'
},

This comment has been minimized.

Copy link
@fabioberger

fabioberger Feb 6, 2020

Contributor

Why was this necessary?

This comment has been minimized.

Copy link
@jalextowle

jalextowle Feb 6, 2020

Author Contributor

For some reason, we get an error that is close to "cannot resolve "fs" in @0x/dev-utils". After doing some reading, this is actually a bug in webpack and is fixed by adding this line. This is the issue I referred to find this solution: webpack-contrib/css-loader#447. After reading the issue again, I'm going dig into this a bit more on a low-priority cycle, because it seems like there is a better way to fix this.

rpc/clients/typescript/test/ws_client_test.ts Outdated Show resolved Hide resolved
@albrow

This comment has been minimized.

Copy link
Member

albrow commented Feb 6, 2020

Just some small suggestions. Looks pretty good overall.

@jalextowle jalextowle force-pushed the test/convert-config-test branch from f7bb1d3 to 2980ff0 Feb 10, 2020
@jalextowle jalextowle requested a review from albrow Feb 10, 2020
@albrow
albrow approved these changes Feb 12, 2020
@jalextowle jalextowle merged commit 0364937 into development Feb 12, 2020
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
continuous-integration/drone/push Build is passing
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.