Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Removed receiverData and `onReceive` callback from ERC721 proxy. #877
In the current proxy implementation, an ERC721 taker has the opportunity to execute code on invalid state.
A transfer looks like this:
This could pose a problem if, for example,
A more robust strategy could be to provide generalized callbacks that are executed after settlement, and which can be used with any proxy. Perhaps this is something we can look into for V3.
All existing tests pass. A new test was created to verify that the ERC721
Types of changes