From 5c3864ab7451e1356c0722d4a9ec0bd6d5895e82 Mon Sep 17 00:00:00 2001 From: xianny Date: Fri, 26 Apr 2019 11:53:17 -0700 Subject: [PATCH] add note explaining that matchOrders is not implemented --- v2/coordinator-specification.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/v2/coordinator-specification.md b/v2/coordinator-specification.md index 2d0ef9b..b9a3b60 100644 --- a/v2/coordinator-specification.md +++ b/v2/coordinator-specification.md @@ -166,6 +166,8 @@ When interacting with coordinator orders, the following Exchange methods must be | [`batchCancelOrders`](https://github.com/0xProject/0x-protocol-specification/blob/master/v2/v2-specification.md#batchcancelorders) | No | | [`cancelOrdersUpTo`](https://github.com/0xProject/0x-protocol-specification/blob/master/v2/v2-specification.md#cancelordersupto) | No | +Note: `matchOrders` is not currently implemented in [0x-coordinator-server](https://github.com/0xProject/0x-coordinator-server). The server will not generate approval signatures for a `matchOrders` request. However, the Coordinator contract still requires approval signatures for any `matchOrders` transactions. As such, `matchOrders` transactions must be executed directly through the Exchange contract. + `executeTransaction` will revert under the following conditions: - The `tx.origin` (Ethereum transaction signer) differs from the passed in `txOrigin` parameter.