Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Remote Cursor/Selection in Ace #60

Closed
0xTheProDev opened this issue Oct 2, 2021 · 4 comments · Fixed by #75
Closed

Support for Remote Cursor/Selection in Ace #60

0xTheProDev opened this issue Oct 2, 2021 · 4 comments · Fixed by #75
Labels
Hacktoberfest Hacktoberfest 2021 Small Story Point v0.2.0 Release Version
Projects
Adapters
Milestone
S-41-43

Comments

@0xTheProDev
Copy link
Owner

No description provided.

@0xTheProDev 0xTheProDev created this issue from a note in Adapters (To do) Oct 2, 2021
@0xTheProDev 0xTheProDev added Hacktoberfest Hacktoberfest 2021 Medium Story Point v0.2.0 Release Version labels Oct 2, 2021
@0xTheProDev 0xTheProDev added this to the S-41-43 milestone Oct 2, 2021
@0xTheProDev 0xTheProDev added Small Story Point and removed Medium Story Point labels Oct 2, 2021
lakbychance added a commit to lakbychance/Operational-Transformation that referenced this issue Oct 6, 2021
@lakbychance
(feat) @otjs/ace: Add remote cursor/selection to Ace
8edd81b 
This commit adds cursor and selection CSS highlighting to ace editor.

Fixes: 0xTheProDev#60

Signed-off-by: Lakshya Thakur lapstjup@gmail.com
@lakbychance lakbychance mentioned this issue Oct 6, 2021
Merged
@lakbychance
Copy link
Contributor

Hey @Progyan1997 , I gave a shot to this issue. Let me know if my changes align with the issue requirements.

@0xTheProDev
Copy link
Owner Author

@lapstjup, Okay now I feel stupid. Great catch and great fix. But now that I have you here, can you give a try to add tooltip/message same as monaco to announce the username?

@0xTheProDev 0xTheProDev moved this from To do to In progress in Adapters Oct 6, 2021
@lakbychance
Copy link
Contributor

@Progyan1997 Might give it a try in a separate issue. Would need to be familiar first as to how you have done it in monaco. I can see there is a dedicated file that goes by cursor-widget.impl.ts that I think is responsible for the tooltip stuff in monaco.

@0xTheProDev
Copy link
Owner Author

Yes, you are right. Closing this one then!

Adapters automation moved this from In progress to Done Oct 6, 2021
0xTheProDev pushed a commit that referenced this issue Oct 6, 2021
@lakbychance
(feat) @otjs/ace: Add remote cursor/selection to Ace
87007fe 
Adds cursor and selection CSS highlighting to ace editor.

Fixes: #60
Signed-off-by: Lakshya Thakur <lapstjup@gmail.com>
@0xTheProDev 0xTheProDev mentioned this issue Oct 6, 2021
Closed
Repository owner locked as resolved and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Hacktoberfest Hacktoberfest 2021 Small Story Point v0.2.0 Release Version
Projects
No open projects
Adapters
  
Done
Milestone
S-41-43
Development

Successfully merging a pull request may close this issue.

(feat) @otjs/ace: Add remote cursor/selection to Ace lakbychance/Operational-Transformation
2 participants
@0xTheProDev @lakbychance