Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) @otjs/ace: Add remote tooltip support to Ace #81

Merged
merged 9 commits into from
Oct 8, 2021

Conversation

lakbychance
Copy link
Contributor

Adds remote tooltip support showcasing username to ace editor.
Files added to src:-

  • cursor-widget.impl.ts
  • cursor-widget.ts

Fixes: #76
Signed-off-by: Lakshya Thakur lapstjup@gmail.com

Adds remote tooltip support showcasing username to ace editor.
Files added to src:-
* cursor-widget.impl.ts
* cursor-widget.ts

Fixes: 0xTheProDev#76
Signed-off-by: Lakshya Thakur <lapstjup@gmail.com>
…e tooltip support showcasing username to ace editor. Files added to src:- * cursor-widget.impl.ts * cursor-widget.ts
@0xTheProDev 0xTheProDev added Hacktoberfest Hacktoberfest Participation v0.2.0 labels Oct 8, 2021
…s remote tooltip support showcasing username to ace editor. Files added to src:- * cursor-widget.impl.ts * cursor-widget.ts
…Ace Adds remote tooltip support showcasing username to ace editor. Files added to src:- * cursor-widget.impl.ts * cursor-widget.ts
…ort to Ace Adds remote tooltip support showcasing username to ace editor. Files added to src:- * cursor-widget.impl.ts * cursor-widget.ts
…ip support to Ace Adds remote tooltip support showcasing username to ace editor. Files added to src:- * cursor-widget.impl.ts * cursor-widget.ts
@lakbychance
Copy link
Contributor Author

@Progyan1997 - I have finalized changes from my end. I took the liberty of debouncing the timer implementations as it gives a smooth UX of tooltip indication when I tested it. Let me know if that's okay with you.

@0xTheProDev 0xTheProDev merged commit 76a1152 into 0xTheProDev:main Oct 8, 2021
Repository owner locked as resolved and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Hacktoberfest Hacktoberfest Participation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Cursor Widget in Ace
2 participants