Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typescript versions for peerDependencies #6

Merged
merged 2 commits into from
Apr 21, 2024

Conversation

svgor-code
Copy link

Hello! Thank you for your work!

This PR proposes changing the required TypeScript version from "^5.3.5" and "^5.4.4" to "^5.0.0". Currently, versions "^5.3.5" "^5.4.4" are causing dependency issues for users of our library as this version does not exist in the npm repository.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: trix@0.0.1
npm ERR! Found: typescript@5.4.5
npm ERR! node_modules/typescript
npm ERR!   dev typescript@"^5.3.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer typescript@"5.3.0" from @token-icons/core@2.3.1
npm ERR! node_modules/@token-icons/core
npm ERR!   @token-icons/core@"^2.3.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Lowering the TypeScript version to "^5.0.0" will address these dependency issues and ensure broader compatibility with various versions of TypeScript.

I am ready to discuss any questions or concerns regarding this proposed change.

@0xa3k5 0xa3k5 merged commit 5fff10f into 0xa3k5:main Apr 21, 2024
1 check was pending
@0xa3k5
Copy link
Owner

0xa3k5 commented Apr 21, 2024

thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants