Fix assertion failure on PDF pages with only an LTFigure and no LTTextBox/Line components #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponents issue #48 demonstrates a PDF where all text is chars within a figure, and there are no lines/boxes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a crash when a page contains annotations and text, but that text is part of an LTFigure component and not an LTTextLine/Box. In this case, the prior logic would fail to assign a sequence number to the annotations on the page. The new logic is not perfect (all annotations inside a "figure" are effectively at the same sequence on the page), but should be good enough given that such PDFs appear to be rare.
Also, improve the warning message for unsupported annotations.
Fixes #48