Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce code style on CI with rustfmt #21

Open
0xazure opened this issue Nov 6, 2018 · 5 comments
Open

Enforce code style on CI with rustfmt #21

0xazure opened this issue Nov 6, 2018 · 5 comments

Comments

@0xazure
Copy link
Owner

@0xazure 0xazure commented Nov 6, 2018

#9 introduces code linting with clippy and running the project's tests. We should take this a step further and ensure consistent coding style in our continuous integration pipeline using rustfmt to ensure consistency.

See https://github.com/rust-lang-nursery/rustfmt#checking-style-on-a-ci-server for a minimal example for setting up rustfmt on CI, as well as this blog post on enforcing style in CI for Rust projects.

@Mordax
Copy link
Contributor

@Mordax Mordax commented Nov 9, 2018

I'd say we should assign @biskit1 (Chaya) to tackle this one - this is a good, not stressful issue to help get acquainted with the code base. If and only if they want of course. Trying to issue squat for a buddeh.

@biskit1
Copy link

@biskit1 biskit1 commented Nov 14, 2018

lol thanks @Mordax!
The other issue I'm working on (and almost finished with) has given me a chance to familiarize myself with the code base, so I guess that makes things a little easier.

I'll try to tackle this over the next few days/weekend. @0xazure can you assign me please?

@0xazure
Copy link
Owner Author

@0xazure 0xazure commented Nov 14, 2018

Sure @biskit1 go for it! GitHub won't seem to let me assign issues to anyone other than myself right now, but this one's all yours.

@0xazure
Copy link
Owner Author

@0xazure 0xazure commented Nov 23, 2018

Hey @biskit1 just wanted to check in to see how things are going with this issue. Let me know if you have any questions, I'm happy to help out!

@biskit1
Copy link

@biskit1 biskit1 commented Nov 28, 2018

Thanks @0xazure. Opened other PR and this is next :) Will get started ASAP and keep you posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.