Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print clippy version on Travis #32

Open
0xazure opened this issue Nov 20, 2018 · 1 comment
Open

Print clippy version on Travis #32

0xazure opened this issue Nov 20, 2018 · 1 comment
Labels
enhancement ✨ New feature or request good first issue 🌟 These issues are good for way to get started with supernova

Comments

@0xazure
Copy link
Owner

0xazure commented Nov 20, 2018

To help better debug issues like those we experienced in #24, we should print the versions of any extra tools we add to CI so we can compare version numbers and build hashes.

Elsewhere in the logs Travis prints out version numbers of the tools:

$ rustc --version
rustc 1.31.0-beta.5 (bf00632e3 2018-11-08)
$ rustup --version
rustup 1.14.0 (1e51b07cc 2018-10-04)
$ cargo --version
cargo 1.31.0-beta (efb7972a0 2018-10-24)

so we should too.

To do this for clippy, we need to run cargo clippy --version after a successful installation in our Travis config:

supernova/.travis.yml

Lines 19 to 20 in f4838f9

before_script:
- if [[ "$TRAVIS_RUST_VERSION" == "stable" || "$TRAVIS_RUST_VERSION" == "nightly" ]]; then rustup component add clippy-preview; fi

so we can get something like:

$ cargo clippy --version
clippy 0.0.212 (125907ad 2018-09-17)

in the build log.

@0xazure 0xazure added enhancement ✨ New feature or request good first issue 🌟 These issues are good for way to get started with supernova labels Nov 20, 2018
biskit1 added a commit to biskit1/supernova that referenced this issue Jan 2, 2019
@biskit1
Copy link

biskit1 commented Jan 15, 2019

Fixed with #39.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request good first issue 🌟 These issues are good for way to get started with supernova
Projects
None yet
Development

No branches or pull requests

2 participants