Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Readme from rst to md #15

Merged
merged 2 commits into from Nov 4, 2018

Conversation

Projects
None yet
2 participants
@Mordax
Copy link
Contributor

Mordax commented Nov 3, 2018

Closes #10 .

@0xazure

This comment has been minimized.

Copy link
Owner

0xazure commented Nov 3, 2018

Hey @Mordax thanks very much for taking on this conversion.

#9 added some content to the README.rst, would you be able to rebase your branch and convert these additions over as well?

@Mordax Mordax force-pushed the Mordax:issue-10 branch from 9b8dae3 to 6848caa Nov 3, 2018

@Mordax

This comment has been minimized.

Copy link
Contributor Author

Mordax commented Nov 3, 2018

Done ✌️

@0xazure
Copy link
Owner

0xazure left a comment

Awesome work @Mordax. Just a couple minor formatting corrections and this is good to merge!

README.md Outdated
@@ -0,0 +1,9 @@
## supernova

This comment has been minimized.

@0xazure

0xazure Nov 3, 2018

Owner
Suggested change
## supernova
# supernova

minor nit: the title should be a first-level header

README.md Outdated
### things learned

- using mem::[replace](https://github.com/rust-unofficial/patterns/blob/master/idioms/mem-replace.md) to [avoid needless clones](https://github.com/rust-unofficial/patterns/blob/master/idioms/mem-replace.md)

This comment has been minimized.

@0xazure

0xazure Nov 3, 2018

Owner

Something I only learned about rst when I tried to make links like this: it doesn't like :: characters inside the link text.

Since Markdown is more permissive, I'd love to see this finally formatted as mem::replace.

@0xazure

0xazure approved these changes Nov 4, 2018

@0xazure

This comment has been minimized.

Copy link
Owner

0xazure commented Nov 4, 2018

Awesome! Thanks very much, @Mordax :shipit:

@0xazure 0xazure merged commit c7cccfb into 0xazure:master Nov 4, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.