Fixing unneeded return linting errors

[Mordax]

Closes #5 . Should remove the annoying failed build badge.

[SeanPrashad]

Great stuff @Mordax! Travis should pass with a green checkmark but it looks like there's some other things breaking the Beta builds.

Check them out here! The error points to Clippy docs: https://rust-lang-nursery.github.io/rust-clippy/v0.0.212/index.html#new_ret_no_self

Looping in @0xazure - do we want to have failing Beta builds fail for Travis?

[0xazure]

Okay, this is interesting. The clippy lint in question is new_ret_no_self, which should have failed on stable as well.

I unfortunately can't dive any deeper on this right now because of rust-lang/rust#55817 so I can't actually install the beta channel to test this locally.

[0xazure]

I'm not actually too fussed about the beta failure because I remove the offending method in #19, but I'd still like to figure out why the two channels are seemingly running different lints against the codebase.

Update: older jobs on beta didn't trigger this lint, so I'm rerunning the beta builds to see what happens. Builds still fail, investigating...

[SeanPrashad]

Luckily we have friends over at #rust:

[0xazure]

clippy on beta is a newer clippy than the clippy on stable

I wish it were that simple. It looks like the new_ret_no_self lint is relatively new (within the last 30-35 days) and experienced a bunch of false positives with the initial implementation. As far as I can tell, stable doesn't include this lint at all, beta has the version with false positives, and nightly has the updated version that eliminates a lot of the false positives seen on beta, which explains why we're only seeing failures on beta.

[0xazure]

Given the above ☝️ and the fact that the tests pass on stable, LGTM 👍

Congrats @Mordax on your first Rust code contribution to the project!!! 🎉 Can't wait to see what's next from you.

[Mordax]

Clearly what's next is a billion dollar app 😎