Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Outputting stars into a properly structured markdown file #26
Hey @Mordax, thanks for taking a crack at fixing our malformed Markdown output!
I've made some inline comments, let me know if you have any questions. Dealing with errors in Rust definitely takes some getting used to, so I tried to provide links to further reading you might be interested in checking out.
From a design standpoint, I'm not sure I like the idea of creating a separate file to write out the results.
supernova should play nicely in a *nix ecosystem, so we definitely want to preserve the ability to pipe the output to various destinations. However, without reading the code it's not obvious that
supernova will create a file, and in this implementation the user isn't able to control either the location or the name of the created file. Since
File::create truncates existing files this could be really bad for an unsuspecting user because it could cause data loss.
Given that, I'm not sure yet how we should move forward with this. Let me know what you think, and I'd be really interested to talk about the design with you!
I'm not sure #33 is relevant, since it's the functionality that should be driving the UI rather than the other way around.
It would be great if we could get this merged, but I definitely agree we need to think about how we expose functionality to the user beyond simply changing how the output is written to its destination.