Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
bug: Do not run clippy on beta toolchain #27
Fixes #25: Do not run clippy on beta toolchain
As observed in #24, we should only invoke Clippy for the
Unfortunately, versions of Clippy vary across channels. With
This is ready for review @0xazure!
I've updated our
Hey @SeanPrashad this is looking really great, and we're green on the builds!
I know you just added a commit to reverse the release channel logic, but I think it would be better to be explicit about which channels we are using rather than filter by the ones we aren't.
Also, I'm looking at the implementation and correct me if I'm wrong but that looks like unix shell conditionals? I'm actually surprised that works correctly on the Windows builds, though a closer reading of the release announcement shows that builds run in a git bash shell, to maintain consistency with other bash-based environments.
I turned up some docs on Travis conditionals, do you know what their relation is to e.g.
I tried to play around with conditionals in Travis but I wasn't able to get the syntax working - see this build (even using the
Upon digging around some more in Travis docs, there was another example that used
I'm willing to spend some more time to figure out how to incorporate Travis conditionals to make the file cleaner if you'd prefer that - let me know!
I've seen the bash-style conditionals in other projects' Travis configs as well, and thanks for linking to those other examples you turned up especially the one for the official docs.
This works as-is and Windows supports bashisms because of Travis' infrastructure, so I'm going to go ahead and merge this
Thanks for taking care of this, our builds should all be green now