Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Update Travis build criteria for branches #30

Merged
merged 1 commit into from Nov 14, 2018
Merged

bug: Update Travis build criteria for branches #30

merged 1 commit into from Nov 14, 2018

Conversation

@seanprashad
Copy link
Contributor

@seanprashad seanprashad commented Nov 14, 2018

Fixes #29: Update Travis build criteria for branches

This PR, in combination with enabling both of the following in the Settings tab for Supernova:

will allow pull requests and only the master branch to be built with Travis.

This is key as owners/contributors of the repo will not fork it for development, meaning their branches will be built prematurely before opening a pull request.

This PR, in combination with enabling both of the following:

1. Build branch updates
2. Build pull request updates

will allow all pull requests to be built using Travis in addition to
only the master branch. This is key as owners/contributors of the repo
will not fork it for development, meaning their branches will be built
pre-maturely before opening a pull request.

Fixes #29
@0xazure
Copy link
Owner

@0xazure 0xazure commented Nov 14, 2018

Aaaaah I was wondering why master wasn't auto-building. I did turn off "Build pushed branches" in the Settings menu, I didn't realize that included master.

I feel like this is a flaw in Travis' config/UI, I don't see much reason why you wouldn't want to build master.

Future note: we may need to change this if we start maintaining release branches, but for now this will save Travis duplicating build work between branches maintainers push and the pull requests they open.

Thanks for the quick fix @seanprashad!

@0xazure 0xazure merged commit 44b7eab into 0xazure:master Nov 14, 2018
1 check passed
@seanprashad seanprashad deleted the issue-29 branch Nov 14, 2018
@seanprashad
Copy link
Contributor Author

@seanprashad seanprashad commented Nov 14, 2018

screen shot 2018-11-14 at 4 06 55 pm

Voila! 🎉🎉

@0xazure
Copy link
Owner

@0xazure 0xazure commented Nov 15, 2018

And we're green 💚 , thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants