New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grabbing main repo language and displaying it #41

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Mordax
Copy link
Contributor

Mordax commented Dec 17, 2018

Closes #40. Adds the main repo language to the Repo struct and implements in a display.

@0xazure

This comment has been minimized.

Copy link
Owner

0xazure commented Dec 19, 2018

Hey @Mordax this looks like a really great addition!

My only concern is about the formatting, I gave this a whirl and got:

[warner/magic-wormhole](https://github.com/warner/magic-wormhole) - get things from one computer to another, safelyMain Language: Python
[VulnReproduction/LinuxFlaw](https://github.com/VulnReproduction/LinuxFlaw) - This repo records all the vulnerabilities of linux software I have reproduced in my local workspaceMain Language: C

note the lack of space between the end of the repo description and "Main Language".

The language information looks a bit lonely hanging off the end there, what if we integrated it a bit more by putting it before the description, maybe in some brackets instead of labeling it?

[warner/magic-wormhole](https://github.com/warner/magic-wormhole) (Python) - get things from one computer to another, safely
[VulnReproduction/LinuxFlaw](https://github.com/VulnReproduction/LinuxFlaw) (C) - This repo records all the vulnerabilities of linux software I have reproduced in my local workspace

which, as Markdown, would render like this:

warner/magic-wormhole (Python) - get things from one computer to another, safely
VulnReproduction/LinuxFlaw (C) - This repo records all the vulnerabilities of linux software I have reproduced in my local workspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment