Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Gateway for deploying smart contract and mutation event parsing #522
…loy-gateway # Conflicts: # common/config/rush/npm-shrinkwrap.json # packages/0xcert-ethereum-sandbox/package.json # packages/0xcert-ethereum-value-ledger/package.json # packages/0xcert-webpack/package.json
fulldecent left a comment •
I have completed a code-level review of this PR. This includes manually reading the code and comparing to advertised or assumed functionality and best practices. Any finding that was previously referenced and which is still relevant to this code is referenced again below, so this is “fresh review”.
Most findings are referenced in code (i.e. GitHub commit comments) here but everything is summarized here.