New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win32 installer and some build issues #252

Merged
merged 12 commits into from Sep 11, 2013

Conversation

Projects
None yet
2 participants
@Maledictus
Copy link
Contributor

Maledictus commented Sep 11, 2013

No description provided.

@@ -2,6 +2,10 @@ cmake_minimum_required (VERSION 2.8)
project (leechcraft_dlniwe)
include (InitLCPlugin OPTIONAL)

set (CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake")

FIND_PACKAGE (HUpnp REQUIRED)

This comment has been minimized.

@0xd34df00d

0xd34df00d Sep 11, 2013

Owner

Мелкими буквами команду.

@@ -102,7 +122,7 @@
str2loc ["DESKTOP"] = QDesktopServices::storageLocation (QDesktopServices::DesktopLocation);
str2loc ["MUSIC"] = QDesktopServices::storageLocation (QDesktopServices::MusicLocation);
str2loc ["MOVIES"] = QDesktopServices::storageLocation (QDesktopServices::MoviesLocation);
str2loc ["LCDIR"] = Util::GetUserDir ({}).absolutePath ();
str2loc ["LCDIR"] = GetUserDir ({}).absolutePath ();

This comment has been minimized.

@0xd34df00d

0xd34df00d Sep 11, 2013

Owner

Чо-т не очень похоже на Windows-онли-кейс.

This comment has been minimized.

@Maledictus

Maledictus Sep 11, 2013

Contributor

в смысле?

This comment has been minimized.

@0xd34df00d

0xd34df00d Sep 11, 2013

Owner

Оберни в #ifdef Q_OS_WIN32, чтобы потом по этому можно было грепнуть и
легко выпилить, а то забудем.

This comment has been minimized.

@Maledictus

Maledictus Sep 11, 2013

Contributor

А зачем это выпиливать? Отсутствие кросслинковки при сборке вполне нормально, не?

This comment has been minimized.

@0xd34df00d

0xd34df00d Sep 11, 2013

Owner

Потому что когда я распилю liblcutil на отдельные либы, кросслинковки не
будет.

Maledictus added some commits Sep 11, 2013

0xd34df00d added a commit that referenced this pull request Sep 11, 2013

Merge pull request #252 from Maledictus/master
Win32 installer and some build issues

@0xd34df00d 0xd34df00d merged commit 1a7be78 into 0xd34df00d:master Sep 11, 2013

1 check failed

default The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment