New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic environment updates #2

Merged
merged 1 commit into from Sep 30, 2014

Conversation

Projects
None yet
2 participants
@evaryont

evaryont commented Sep 28, 2014

Parse .env.example (in a simple fashion) and create .env based on the merge of the default values and any user-specified ones.

You also previously asked about disabling provisioning. Vagrant supports disabling provisioning via the --no-provision command line flag (opt-out behavior) which I find more convenient. We could switch to an opt-in behavior, but I think provisioning by default is the expected behavior. Either way, we should document the additional behavior in the README.

@evaryont evaryont referenced this pull request Sep 28, 2014

Closed

Vagrant changes #1

@0xdevalias

This comment has been minimized.

Show comment
Hide comment
@0xdevalias

0xdevalias Sep 28, 2014

Owner

Would I be able to be a pain and get you to update your pull request for the changes i've made today please?

Should be a lot cleaner/stable now as it actually works (for ubuntu) and i've cleared out a lot of the old random outdated code.

Owner

0xdevalias commented Sep 28, 2014

Would I be able to be a pain and get you to update your pull request for the changes i've made today please?

Should be a lot cleaner/stable now as it actually works (for ubuntu) and i've cleared out a lot of the old random outdated code.

Dynamic dotenv configuration
Parse .env.example (in a simple fashion) and create .env based on the merge of
the default values and any user-specified ones.
@evaryont

This comment has been minimized.

Show comment
Hide comment
@evaryont

evaryont Sep 29, 2014

Simplified the commit, and rebased off of your latest changes (as of 31 hours ago)

evaryont commented Sep 29, 2014

Simplified the commit, and rebased off of your latest changes (as of 31 hours ago)

@0xdevalias

This comment has been minimized.

Show comment
Hide comment
@0xdevalias

0xdevalias Sep 29, 2014

Owner

Had a quick scan over and looks awesome! Will have a bit of a closer look when I get a chance and then get it merged in! :3 Cheers

Owner

0xdevalias commented Sep 29, 2014

Had a quick scan over and looks awesome! Will have a bit of a closer look when I get a chance and then get it merged in! :3 Cheers

0xdevalias added a commit that referenced this pull request Sep 30, 2014

Merge pull request #2 from evaryont/devalias
Dynamic environment updates

@0xdevalias 0xdevalias merged commit e247f06 into 0xdevalias:devalias Sep 30, 2014

@0xdevalias

This comment has been minimized.

Show comment
Hide comment
@0xdevalias
Owner

0xdevalias commented Sep 30, 2014

Thanks @evaryont !!

@evaryont

This comment has been minimized.

Show comment
Hide comment
@evaryont

evaryont Sep 30, 2014

Hurray! Its merged!
On Sep 30, 2014 12:29 AM, "alias1" notifications@github.com wrote:

Thanks @evaryont https://github.com/evaryont !!


Reply to this email directly or view it on GitHub
#2 (comment).

evaryont commented Sep 30, 2014

Hurray! Its merged!
On Sep 30, 2014 12:29 AM, "alias1" notifications@github.com wrote:

Thanks @evaryont https://github.com/evaryont !!


Reply to this email directly or view it on GitHub
#2 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment