Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDynamic environment updates #2
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
0xdevalias
Sep 28, 2014
Owner
Would I be able to be a pain and get you to update your pull request for the changes i've made today please?
Should be a lot cleaner/stable now as it actually works (for ubuntu) and i've cleared out a lot of the old random outdated code.
|
Would I be able to be a pain and get you to update your pull request for the changes i've made today please? Should be a lot cleaner/stable now as it actually works (for ubuntu) and i've cleared out a lot of the old random outdated code. |
0xdevalias
referenced this pull request
Sep 28, 2014
Closed
Extract and upgrade Chef deployment to work properly with CentOS, Ubuntu, Vagrant and Docker [BOUNTY] #416
evaryont
referenced this pull request
Sep 29, 2014
Open
[ubuntu-12.04] Error executing action `run` on resource 'execute[rake-db-create]' #3
referenced
this pull request
Sep 29, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evaryont
Sep 29, 2014
Simplified the commit, and rebased off of your latest changes (as of 31 hours ago)
evaryont
commented
Sep 29, 2014
|
Simplified the commit, and rebased off of your latest changes (as of 31 hours ago) |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
0xdevalias
Sep 29, 2014
Owner
Had a quick scan over and looks awesome! Will have a bit of a closer look when I get a chance and then get it merged in! :3 Cheers
|
Had a quick scan over and looks awesome! Will have a bit of a closer look when I get a chance and then get it merged in! :3 Cheers |
added a commit
that referenced
this pull request
Sep 30, 2014
0xdevalias
merged commit e247f06
into
0xdevalias:devalias
Sep 30, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Thanks @evaryont !! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
evaryont
Sep 30, 2014
Hurray! Its merged!
On Sep 30, 2014 12:29 AM, "alias1" notifications@github.com wrote:
Thanks @evaryont https://github.com/evaryont !!
—
Reply to this email directly or view it on GitHub
#2 (comment).
evaryont
commented
Sep 30, 2014
|
Hurray! Its merged!
|
evaryont commentedSep 28, 2014
Parse
.env.example(in a simple fashion) and create.envbased on the merge of the default values and any user-specified ones.You also previously asked about disabling provisioning. Vagrant supports disabling provisioning via the
--no-provisioncommand line flag (opt-out behavior) which I find more convenient. We could switch to an opt-in behavior, but I think provisioning by default is the expected behavior. Either way, we should document the additional behavior in the README.