Bottom aligned annotations #19

Merged
merged 3 commits into from Jul 3, 2011

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Jun 25, 2011

Hey 0xfe,

I just started using your VexFlow library and I am loving it. It is a great piece of work.

For my requirements it would be nice to have annotations under the stave, so I have added that feature. If you look at the test that I have added, you can see when this might be handy.

I hope you can use this feature in the main VexFlow branch. If you have any suggestions for me to fit your coding standard more closely, I will be happy to make the changes and submit to you again.

Thanks,

Clinton.

Owner

0xfe commented Jun 26, 2011

Hi Clinton,

Thanks very much for the commits. Bottom annotations are certainly a useful feature. I'll review them shortly and get back to you.

Mohit.

Clinton Forbes Got all tests to run in IE 9. (Added DOCTYPE and removed obsolete 'ce…
…nter' element which has been removed from HTML 5)
a42eacb
@ghost

ghost commented Jun 28, 2011

Hey Mohit,
I also got the test suite to run in Internet Explorer 9. Only small changes.
Clinton.

@ghost

ghost commented Jun 30, 2011

Hi Mohit,

How do I correctly render notes to a bass staff? I have added a bass clef but any notes that I render are six lines too low (the treble positions). I have looked through the code but can't find an example in the tests or anything else.

If this is not yet a supported feature then I will submit a patch to you.

Thanks,

Clinton.

On Sunday, 26 June 2011 at 8:39 PM, 0xfe wrote:

Hi Clinton,

Thanks very much for the commits. Bottom annotations are certainly a useful feature. I'll review them shortly and get back to you.

Mohit.

Reply to this email directly or view it on GitHub:
#19 (comment)

Owner

0xfe commented Jun 30, 2011

Yep, this is a bug and I will gladly accept a patch. The fix would be as follows:

  • Add a new key called "clef" to the "note_struct" constructor of StaveNote (stavenote.js)
  • Make Vex.Flow.keyProperties take "clef" as an optional parameter and return the correct line.
  • Add tests :-)

Let me know if you have any issues, Thanks.

@ghost

ghost commented Jun 30, 2011

Cool. Thanks for the tips.

I will work on that over the weekend and send you through my changes.

See-ya,

Clinton.

On Thursday, 30 June 2011 at 9:56 PM, 0xfe wrote:

Yep, this is a bug and I will gladly accept a patch. The fix would be as follows:

  • Add a new key called "clef" to the "note_struct" constructor of StaveNote (stavenote.js)
  • Make Vex.Flow.keyProperties take "clef" as an optional parameter and return the correct line.
  • Add tests :-)

Let me know if you have any issues, Thanks.

Reply to this email directly or view it on GitHub:
#19 (comment)

@ghost

ghost commented Jul 3, 2011

Hi Mohit,

The fix for bass clef notes was dead simple following your notes. About five minutes work. Have added tests and all looks good.

I am guessing you are more into guitar than piano, correct?

See-ya,

Clinton.

Owner

0xfe commented Jul 3, 2011

On Sun, Jul 3, 2011 at 3:48 AM, clinton <
reply@reply.github.com>wrote:

Hi Mohit,

The fix for bass clef notes was dead simple following your notes. About
five minutes work. Have added tests and all looks good.

LOL. Good stuff. Thanks. I'll take a look shortly.

If you're looking for something a bit more challenging (and clamored for),
consider working on a LyricStave -- basically a blank stave where you would
stick lyrics that are aligned with the notation. (See TabStave for a more
complex example.)

I am guessing you are more into guitar than piano, correct?

Yes... how did you guess? ;-)

Now all I need is to find a drummer to implement a DrumStave.

Mohit.

See-ya,

Clinton.

Reply to this email directly or view it on GitHub:
#19 (comment)

Mohit Muthanna [mohit (at) muthanna (uhuh) com]

@0xfe 0xfe merged commit 1bb1530 into 0xfe:master Jul 3, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment