Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collections/vector: implement dynamic table described in `CLRS` #2

Merged
merged 17 commits into from Aug 7, 2019

Conversation

@fengkx
Copy link
Contributor

commented Aug 4, 2019

Fix issue #1

fengkx added some commits Aug 4, 2019

@fengkx fengkx changed the title feat(vector): dynamic grow capity feat(vector): dynamic grow capacity Aug 5, 2019

src/collections/vector.h Outdated Show resolved Hide resolved
src/collections/vector.h Outdated Show resolved Hide resolved
src/collections/vector.h Outdated Show resolved Hide resolved
src/collections/vector.h Outdated Show resolved Hide resolved
@iosmanthus

This comment has been minimized.

Copy link
Collaborator

commented Aug 5, 2019

Please add some tests to new added public methods @fengkx

tests/test-vector.cc Outdated Show resolved Hide resolved
src/collections/vector.h Outdated Show resolved Hide resolved

@iosmanthus iosmanthus changed the title feat(vector): dynamic grow capacity collections/vector: implement dynamic table described in `CLRS` Aug 5, 2019

@iosmanthus
Copy link
Collaborator

left a comment

Excellent work! 👍

src/collections/vector.h Outdated Show resolved Hide resolved
src/collections/vector.h Outdated Show resolved Hide resolved
src/collections/vector.h Outdated Show resolved Hide resolved
src/collections/vector.h Show resolved Hide resolved
src/collections/vector.h Show resolved Hide resolved
tests/test-vector.cc Show resolved Hide resolved
tests/test-vector.cc Show resolved Hide resolved
src/collections/vector.h Outdated Show resolved Hide resolved
src/collections/vector.h Outdated Show resolved Hide resolved
src/collections/vector.h Outdated Show resolved Hide resolved

fengkx added some commits Aug 6, 2019

src/collections/vector.h Outdated Show resolved Hide resolved
tests/test-vector.cc Outdated Show resolved Hide resolved

@iosmanthus iosmanthus merged commit 789f694 into 0xffff-one:master Aug 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.