Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change globalObject to use this in Webpack Config #21

Closed
0xTheProDev opened this issue Sep 5, 2021 · 0 comments · Fixed by #22
Closed

Change globalObject to use this in Webpack Config #21

0xTheProDev opened this issue Sep 5, 2021 · 0 comments · Fixed by #22
Assignees
@0xTheProDev
Labels
Patch Release Version Small Story Point
Milestone
S-35-37

Comments

@0xTheProDev
Copy link
Owner

Ref: https://webpack.js.org/configuration/output/#outputglobalobject
@0xTheProDev 0xTheProDev added this to the S-35-37 milestone Sep 5, 2021
@0xTheProDev 0xTheProDev added Small Story Point v0.2.0 labels Sep 5, 2021
@0xTheProDev 0xTheProDev self-assigned this Sep 5, 2021
@0xTheProDev 0xTheProDev added Patch Release Version and removed v0.2.0 labels Sep 5, 2021
0xTheProDev added a commit that referenced this issue Sep 5, 2021
@0xTheProDev
(fix) Built Artifact: Support for Universal Application
2c56e70 
Change `library.globalObject` to use `this` in Webpack Config. This will enable usage of the library in both Web (Browsers) and Node.

Fixes: #21
Signed-off-by: Progyan Bhattacharya <bprogyan@gmail.com>
@0xTheProDev 0xTheProDev mentioned this issue Sep 5, 2021
Merged
0xTheProDev added a commit that referenced this issue Sep 5, 2021
@0xTheProDev
(fix) Built Artifact: Support for Universal Application
96829e8 
Change `library.globalObject` to use `this` in Webpack Config. This will enable usage of the library in both Web (Browsers) and Node.

Fixes: #21
Signed-off-by: Progyan Bhattacharya <bprogyan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xTheProDev 0xTheProDev

Labels
Patch Release Version Small Story Point
Projects
None yet
Milestone
S-35-37
Development

Successfully merging a pull request may close this issue.

(fix) Built Artifact: Support for Universal Application 0xTheProDev/Operational-Transformation
1 participant
@0xTheProDev