Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upTests pass using swift package manager on Linux and Mac, using Swift 4.0.2 #23
Conversation
added some commits
Nov 7, 2017
1024jp
merged commit fc9fb73
into
1024jp:develop
Nov 7, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
This is great! |
This comment has been minimized.
This comment has been minimized.
danramteke
commented
Nov 8, 2017
|
Great! Glad you like it! Perhaps at the top of #if os(Linux)
import zlibLinux
#else
import zlib
#endifinstead of #if os(OSX)
import zlib
#elseif os(Linux)
import zlibLinux
#endifin order to support os's that are not OSX or Linux. |
added a commit
that referenced
this pull request
Nov 11, 2017
1024jp
referenced this pull request
Nov 11, 2017
Closed
xcode 9 iOS11 GzipSwift/zlib/module.modulemap:1:8: note: previously defined here module zlib [system] #19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
danramteke commentedNov 7, 2017
No description provided.