Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests pass using swift package manager on Linux and Mac, using Swift 4.0.2 #23

Merged
merged 6 commits into from Nov 7, 2017

Conversation

@danramteke
Copy link

@danramteke danramteke commented Nov 7, 2017

No description provided.

@1024jp 1024jp merged commit fc9fb73 into 1024jp:develop Nov 7, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@1024jp
Copy link
Owner

@1024jp 1024jp commented Nov 7, 2017

This is great!
Thank you @danramteke.

@danramteke
Copy link
Author

@danramteke danramteke commented Nov 8, 2017

Great! Glad you like it!

Perhaps at the top of Data+Gzip.swift the imports should be

#if os(Linux)
  import zlibLinux
#else
  import zlib
#endif

instead of

#if os(OSX)
import zlib
#elseif os(Linux)
import zlibLinux
#endif

in order to support os's that are not OSX or Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants