Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation for destructive WP-CLI commands #2120

Merged

Conversation

Rahmon
Copy link
Contributor

@Rahmon Rahmon commented Mar 8, 2021

Description of the Change

This change adds confirmation for destructive WP-CLI commands.

Alternate Designs

Benefits

Preventing accidentally run destructive WP-CLI commands.

Possible Drawbacks

Verification Process

Running the commands below should show a confirmation message before:

  • wp elasticpress delete-index
  • wp elasticpress index --setup

Providing --yes skips the prompt.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes: #1713

Changelog Entry

Added confirmation for destructive WP-CLI commands

@Rahmon Rahmon self-assigned this Mar 8, 2021
@oscarssanchez
Copy link
Contributor

Looks good @Rahmon , can you update the branch to the latest ? This way tests that were cancelled will run automatically.

@Rahmon
Copy link
Contributor Author

Rahmon commented Apr 16, 2021

@oscarssanchez I've updated the branch.

@Rahmon Rahmon assigned oscarssanchez and unassigned Rahmon Apr 22, 2021
@brandwaffle brandwaffle merged commit 0a557f2 into develop Apr 30, 2021
@brandwaffle brandwaffle deleted the feature/add-confirmation-for-destructive-wp-cli-issue-1713 branch April 30, 2021 17:19
@Rahmon Rahmon added this to the 3.6.0 milestone Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning + confirmation for destructive WP-CLI commands
3 participants