Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP8 compatibility workflow #118

Merged
merged 5 commits into from Apr 18, 2022
Merged

Add PHP8 compatibility workflow #118

merged 5 commits into from Apr 18, 2022

Conversation

Sidsector9
Copy link
Member

@Sidsector9 Sidsector9 commented Mar 28, 2022 •
edited

Description of the Change

Merge PR #116 before merging this one.

  • Added PHP compatibility tests for PHP minimum 5.6
  • Bumped minimum WordPress version to 5.4 as this plugin doesn't work for the below versions

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Credits

Props @

@Sidsector9 Sidsector9 self-assigned this Apr 2, 2022
@Sidsector9 Sidsector9 requested review from a team and dkotter and removed request for a team April 2, 2022 15:23
dkotter
dkotter previously approved these changes Apr 4, 2022
View reviewed changes
@jeffpaul
Copy link
Member

@Sidsector9 another conflict to try and resolve so this can get to merge

@jeffpaul jeffpaul added this to the 1.1.0 milestone Apr 18, 2022
@jeffpaul jeffpaul merged commit 3858b9b into develop Apr 18, 2022
@jeffpaul jeffpaul deleted the php8-compat branch April 18, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter left review comments

@jeffpaul jeffpaul Awaiting requested review from jeffpaul jeffpaul is a code owner

Assignees

@Sidsector9 Sidsector9

Labels
None yet
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sidsector9 @jeffpaul @dkotter