New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would be cool to use SRM methods in other plugins #9

Merged
merged 1 commit into from Sep 5, 2012

Conversation

Projects
None yet
3 participants
@simonwheatley
Contributor

simonwheatley commented Sep 5, 2012

I recently wrote a quick, disposable importer plugin for SRM and needed to access the sanitise methods and meta key name properties. With the instantiation of the SRM_Safe_Redirect_Manager class not set to a var this wasn't possible. Here's a writeup: http://simonwheatley.co.uk/2012/09/safe-redirect-manager-import/

Might be handy if you considered this as a change.

Thanks!

Simon

Set a global for the Safe Redirect Manager object so it's public meth…
…ods and properties can be accessed by other plugins.
@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Sep 5, 2012

Contributor

I'll leave merging to @tlovett1, but I think it would be pretty darn neat to include a CSV importer as a WP-CLI command..

Contributor

danielbachhuber commented Sep 5, 2012

I'll leave merging to @tlovett1, but I think it would be pretty darn neat to include a CSV importer as a WP-CLI command..

@simonwheatley

This comment has been minimized.

Show comment
Hide comment
@simonwheatley

simonwheatley Sep 5, 2012

Contributor

I nearly wrote this as a CSV importer for SRM, but then swerved at the last minute and did something quick, dirty and separate which used the SRM methods.

To avoid doubt: this change doesn't add any functionality to the SRM plugin, it makes it possible to use the methods on the object from elsewhere.

Contributor

simonwheatley commented Sep 5, 2012

I nearly wrote this as a CSV importer for SRM, but then swerved at the last minute and did something quick, dirty and separate which used the SRM methods.

To avoid doubt: this change doesn't add any functionality to the SRM plugin, it makes it possible to use the methods on the object from elsewhere.

@tlovett1

This comment has been minimized.

Show comment
Hide comment
@tlovett1

tlovett1 Sep 5, 2012

Member

I'm merging this.

A CSV importer would definitely be a good idea.

Member

tlovett1 commented Sep 5, 2012

I'm merging this.

A CSV importer would definitely be a good idea.

tlovett1 added a commit that referenced this pull request Sep 5, 2012

Merge pull request #9 from simonwheatley/master
Would be cool to use SRM methods in other plugins

@tlovett1 tlovett1 merged commit 3a66f68 into 10up:master Sep 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment