Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore textarea-input elements from dragging #21

Merged
merged 3 commits into from May 1, 2018

Conversation

oscarssanchez
Copy link
Contributor

@oscarssanchez oscarssanchez commented Apr 20, 2018

Hi @helen,

Could you use this PR to solve: #13, #20 .

I made use of the suggestion made here: https://wordpress.org/support/topic/exception-for-inputs-suggestion/ and it seems you don't even have to create a new script file.

Another solution I tried successfully was to just knock out cancel: '.inline-edit-row', . It seems the class is not used in the plugin besides there, but since i don't know the reason it was added in the first place, I opted for the first solution.

In my testing, both solutions make possible to edit textarea elements while keeping the rest of the dragging functions intact.

It would be cool if someone can test this out also as I may have missed something.

@helen
Copy link
Contributor

@helen helen commented May 1, 2018

This looks good to me, I'll push the built JS to your branch and get this merged.

@helen helen force-pushed the fix/ignore-input-elements-in-row branch from 0da12ea to cd7876b Compare May 1, 2018
@helen helen merged commit fb488f3 into 10up:develop May 1, 2018
@oscarssanchez
Copy link
Contributor Author

@oscarssanchez oscarssanchez commented May 1, 2018

Great, thank you @helen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants