Ignore textarea-input elements from dragging #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, I'll push the built JS to your branch and get this merged. |
helen
force-pushed
the
fix/ignore-input-elements-in-row
branch
from
0da12ea
to
cd7876b
Compare
|
Great, thank you @helen |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hi @helen,
Could you use this PR to solve: #13, #20 .
I made use of the suggestion made here: https://wordpress.org/support/topic/exception-for-inputs-suggestion/ and it seems you don't even have to create a new script file.
Another solution I tried successfully was to just knock out
cancel: '.inline-edit-row',. It seems the class is not used in the plugin besides there, but since i don't know the reason it was added in the first place, I opted for the first solution.In my testing, both solutions make possible to edit
textareaelements while keeping the rest of the dragging functions intact.It would be cool if someone can test this out also as I may have missed something.