New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose nginx logs and add basic Xdebug configuration #38

Closed
wants to merge 5 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@moraleida
Contributor

moraleida commented Jun 1, 2017

This does 2 things:
Exposes nginx and xdebug logs files to facilitate debugging.
Adds basic Xdebug configurations to work out of the box.

It is my current setup on Linux and has been tested lightly on Windows 10. It works as described, except on Windows the IP address is different for every setup - so I added a specific note for this on the readme. It should work out of the box for macs too but I don't have a way to test it.

[Xdebug]
xdebug.remote_enable = 1
xdebug.remote_log = /var/log/xdebug/xdebug.log
xdebug.remote_host = 172.18.0.1

This comment has been minimized.

@dwainm

dwainm Jun 13, 2017

Which IP address does this point to? Is it gauranteed to be the same for all users?

@dwainm

dwainm Jun 13, 2017

Which IP address does this point to? Is it gauranteed to be the same for all users?

This comment has been minimized.

@moraleida

moraleida Jun 13, 2017

Contributor

172.18.0.1 is the address defined on docker-compose.yml. It works on any linux install - untested on Macs but it should work too. Does not work on Windows installs (see note above and on the readme.md).

@moraleida

moraleida Jun 13, 2017

Contributor

172.18.0.1 is the address defined on docker-compose.yml. It works on any linux install - untested on Macs but it should work too. Does not work on Windows installs (see note above and on the readme.md).

This comment has been minimized.

@cr101

cr101 Jun 14, 2017

Is there a way to make it work on Windows as well?

@cr101

cr101 Jun 14, 2017

Is there a way to make it work on Windows as well?

This comment has been minimized.

@moraleida

moraleida Jun 14, 2017

Contributor

Check the updated readme. On Windows that IP is your network bridge adapter IP - docker creates this when you install. It should be in the same range as your machine, so 192.168.x.x

@moraleida

moraleida Jun 14, 2017

Contributor

Check the updated readme. On Windows that IP is your network bridge adapter IP - docker creates this when you install. It should be in the same range as your machine, so 192.168.x.x

@tlovett1

This comment has been minimized.

Show comment
Hide comment
@tlovett1

tlovett1 Jun 29, 2017

Member

This looks well written. I personally almost never use remote debugging via xdebug. @cmmarslender thoughts?

Member

tlovett1 commented Jun 29, 2017

This looks well written. I personally almost never use remote debugging via xdebug. @cmmarslender thoughts?

@cmmarslender

This comment has been minimized.

Show comment
Hide comment
@cmmarslender

cmmarslender Jun 29, 2017

Contributor

@tlovett1 I think I'd be ok with merging it. Would be nice to have the support a bit more baked in + the instructions for those that do use it more often.

@moraleida there seems to be a conflict with docker-compose.yml - mind fixing that so we can merge?

Contributor

cmmarslender commented Jun 29, 2017

@tlovett1 I think I'd be ok with merging it. Would be nice to have the support a bit more baked in + the instructions for those that do use it more often.

@moraleida there seems to be a conflict with docker-compose.yml - mind fixing that so we can merge?

@cmmarslender

This comment has been minimized.

Show comment
Hide comment
@cmmarslender

cmmarslender Jun 29, 2017

Contributor

Talked to Ricardo, and this had yet to be tested on a mac. A quick test doesn't seem that it actually works on mac currently, so maybe we can open an issue for now and document the steps on how to get this to work on any system we know (for know) and once we get the details of how to get it working on all platforms, we can take another stab at a PR.

Contributor

cmmarslender commented Jun 29, 2017

Talked to Ricardo, and this had yet to be tested on a mac. A quick test doesn't seem that it actually works on mac currently, so maybe we can open an issue for now and document the steps on how to get this to work on any system we know (for know) and once we get the details of how to get it working on all platforms, we can take another stab at a PR.

moraleida added a commit to moraleida/wp-local-docker that referenced this pull request Jul 27, 2017

benoitchantre added a commit to benoitchantre/wp-local-docker that referenced this pull request Feb 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment