Skip to content

fix: change missing arg from empty string to undefined#3789

Closed
btrem wants to merge 1 commit into
11ty:mainfrom
btrem:issue_3788_nunjucks_shortcode
Closed

fix: change missing arg from empty string to undefined#3789
btrem wants to merge 1 commit into
11ty:mainfrom
btrem:issue_3788_nunjucks_shortcode

Conversation

@btrem

@btrem btrem commented May 1, 2025

Copy link
Copy Markdown

May resolve #3788.

NB Needs testing.

@btrem
btrem requested a review from zachleat as a code owner May 1, 2025 00:58
@btrem

btrem commented May 1, 2025

Copy link
Copy Markdown
Author

@zachleat I don't know how to test a branch of 11ty, so I can't check that what I've done doesn't break something, or reintroduce #372. (And even if I could test a branch, I'm not sure I'd know how to test the change I've made.)

@zachleat

Copy link
Copy Markdown
Member

You were close on this one! I think there is a better path forward at #3822 though. Thanks for the effort!

@zachleat zachleat closed this May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

nunjucks shortcodes with no parameter passes empty string to function

2 participants