Fix regression with #hash and ?search links and InputPathToUrl plugin.

11ty · Jun 11, 2024 · b60027f · b60027f
1 parent 245db98
commit b60027f
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 1 deletion.
diff --git a/src/Plugins/InputPathToUrl.js b/src/Plugins/InputPathToUrl.js
@@ -1,3 +1,4 @@
+import path from "node:path";
 import { TemplatePath } from "@11ty/eleventy-utils";
 import isValidUrl from "../Util/ValidUrl.js";
 
@@ -40,10 +41,15 @@ function parseFilePath(filepath) {
 			hash: '#anchor'
 		} */
 
+		// URL(`file:#anchor`) gives back a pathname of `/`
+		if (filepath.startsWith("#") || filepath.startsWith("?")) {
+			return ["", filepath];
+		}
+
 		// Note that `node:url` -> pathToFileURL creates an absolute path, which we don’t want
 		let u = new URL(`file:${filepath}`);
 		return [
-			// hash includes # sign
+			// search includes ?, hash includes #
 			u.search + u.hash,
 			u.pathname,
 		];

diff --git a/test/InputPathToUrlPluginTest.js b/test/InputPathToUrlPluginTest.js
@@ -19,6 +19,8 @@ const OUTPUT_HTML_STD = `<!doctype html>
 <a href="/">Home</a>
 <a href="/tmpl/">Test</a>
 <a href="/tmpl/#anchor">Anchor</a>
+<a href="#anchor">Anchor</a>
+<a href="?search=1">Search</a>
 </body>
 </html>`;
 
@@ -36,6 +38,8 @@ const OUTPUT_HTML_BASE = `<!doctype html>
 <a href="/gh-pages/">Home</a>
 <a href="/gh-pages/tmpl/">Test</a>
 <a href="/gh-pages/tmpl/#anchor">Anchor</a>
+<a href="#anchor">Anchor</a>
+<a href="?search=1">Search</a>
 </body>
 </html>`;
 

diff --git a/test/stubs-pathtourl/filter.njk b/test/stubs-pathtourl/filter.njk
@@ -12,5 +12,7 @@
 <a href="/">Home</a>
 <a href="{{ 'tmpl.njk' | inputPathToUrl }}">Test</a>
 <a href="{{ 'tmpl.njk#anchor' | inputPathToUrl }}">Anchor</a>
+<a href="#anchor">Anchor</a>
+<a href="?search=1">Search</a>
 </body>
 </html>
diff --git a/test/stubs-pathtourl/transform.njk b/test/stubs-pathtourl/transform.njk
@@ -12,5 +12,7 @@
 <a href="/">Home</a>
 <a href="tmpl.njk">Test</a>
 <a href="tmpl.njk#anchor">Anchor</a>
+<a href="#anchor">Anchor</a>
+<a href="?search=1">Search</a>
 </body>
 </html>