Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser-sync to 2.27.6 #2054

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Update browser-sync to 2.27.6 #2054

merged 1 commit into from
Oct 26, 2021

Conversation

ThewBear
Copy link
Contributor

The version of ua-parser-js used by browser-sync v2.27.5 contains a crypto-miner malware.

BrowserSync/browser-sync#1914

Please consider release the security fix to v0.12.x branch since this is a critical severity vulnerability.

@zachleat
Copy link
Member

I think 0.x uses 2.26.x https://github.com/11ty/eleventy/blob/v0.x/package.json

But new installs to 1.x (via ^2.27.5) will install 2.27.6 because of the ^. I don’t think existing installs and those locked in from a package-lock.json would get 2.27.6 even with a new beta release? All that said, I will definitely issue a new 1.x that points to the updated version.

@zachleat
Copy link
Member

Actually, I misspoke—sorry. A fresh Eleventy install using 0.12.1 (via npm install @11ty/eleventy) uses the latest browser-sync 2.27.6

image

@zachleat zachleat added this to the Eleventy 1.0.0 milestone Oct 26, 2021
@zachleat zachleat merged commit 429a366 into 11ty:master Oct 26, 2021
@zachleat
Copy link
Member

zachleat commented Oct 26, 2021

Shipping with 1.0.0-beta.3.

Any existing installs in the wild that are tied to browser-sync 2.27.5 (on 0.x or 1.x) will likely still have the problematic version locally.

@zachleat
Copy link
Member

To make sure this doesn’t affect your install of Eleventy, you can:

  1. Nuclear option and clean out/reinstall your node_modules
  2. npm install browser-sync to update your local browser-sync to the latest fixed version.

To know whether this affects you, you’ll want to look in your package-lock.json for ua-parser-js for versions 0.7.29, 0.8.0, or 1.0.0: faisalman/ua-parser-js#536 (comment) (via browser-sync 2.27.5)

@DanielRuf
Copy link

The affected versions were removed after about 4 hours on Friday (22nd of October) and new clean releases were published.

See also faisalman/ua-parser-js#536 (comment)

@marcfilleul
Copy link

I was using eleventy 1.0 beta 2 and after running yarn upgrade, I'm now using eleventy 1.0 canary 44 with updated browsersync 2.27.7 and ua-parser-js 1.0.2.

So I don't need to clean out everything?

@zachleat
Copy link
Member

zachleat commented Oct 29, 2021

@marcfilleul If you don’t have the noted versions you should be fine. But for the beta -> canary swap you may want to read this #2009

@marcfilleul
Copy link

@zachleat Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants