Optimise replace brush to be around 15% faster (when run under profiler)

Author: UnknownShadow200

fCraft/Drawing/Brushes/BWRainbowBrush.cs

@@ -56,8 +56,6 @@ public bool Begin(Player player, DrawOperation state) {
 
 
         public Block NextBlock(DrawOperation state) {
-            if (state == null)
-                throw new ArgumentNullException("state");
             return BWRainbow[(state.Coords.X + state.Coords.Y + state.Coords.Z) % 8];
         }
 

fCraft/Drawing/Brushes/CheckeredBrush.cs

@@ -105,8 +105,6 @@ public bool Begin(Player player, DrawOperation state) {
 
 
         public Block NextBlock(DrawOperation state) {
-            if (state == null)
-                throw new ArgumentNullException("state");
             if (((state.Coords.X + state.Coords.Y + state.Coords.Z) & 1) == 1) {
                 return Block1;
             } else {

fCraft/Drawing/Brushes/CloudyBrush.cs

@@ -334,8 +334,6 @@ public bool Begin(Player player, DrawOperation op) {
 
 
         public Block NextBlock(DrawOperation op) {
-            if (op == null)
-                throw new ArgumentNullException("op");
             Vector3I relativeCoords = op.Coords - op.Bounds.MinVertex;
             float value = noise3D.Compute(relativeCoords.X, relativeCoords.Y, relativeCoords.Z);
 

fCraft/Drawing/Brushes/NormalBrush.cs

@@ -103,8 +103,6 @@ public bool Begin(Player player, DrawOperation state) {
 
 
         public Block NextBlock(DrawOperation state) {
-            if (state == null)
-                throw new ArgumentNullException("state");
             if (state.AlternateBlockIndex < Blocks.Length) {
                 return Blocks[state.AlternateBlockIndex];
             } else {

fCraft/Drawing/Brushes/PasteBrush.cs

@@ -138,8 +138,6 @@ public bool Begin(Player player, DrawOperation op) {
 
 
         public Block NextBlock(DrawOperation op) {
-            if (op == null) throw new ArgumentNullException("op");
-
             // TODO: offset op.Coords
             Vector3I pasteCoords = new Vector3I {
                 X = Mod(op.Coords.X - op.Marks[0].X, CopyInfo.Bounds.Width),

fCraft/Drawing/Brushes/RainbowBrush.cs

@@ -67,8 +67,6 @@ public bool Begin(Player player, DrawOperation state) {
 
 
         public Block NextBlock(DrawOperation state) {
-            if (state == null)
-                throw new ArgumentNullException("state");
             return Rainbow[(state.Coords.X + state.Coords.Y + state.Coords.Z) % 13];
         }
 

fCraft/Drawing/Brushes/RandomBrush.cs

@@ -154,8 +154,6 @@ public bool Begin(Player player, DrawOperation op) {
 
 
         public Block NextBlock(DrawOperation op) {
-            if (op == null)
-                throw new ArgumentNullException("op");
             int n = seed ^ (op.Coords.X + 1290 * op.Coords.Y + 1664510 * op.Coords.Z);
             n = (n << 13) ^ n;
             n = (n * (n * n * 15731 + 789221) + 1376312589) & 0x7FFFFFFF;

fCraft/Drawing/Brushes/ReplaceBrush.cs

@@ -122,9 +122,7 @@ public bool Begin(Player player, DrawOperation op) {
 
 
         public virtual Block NextBlock(DrawOperation op) {
-            if (op == null)
-                throw new ArgumentNullException("op");
-            Block block = op.Map.GetBlock(op.Coords);
+            Block block = (Block)op.Map.Blocks[op.Map.Index(op.Coords)];
             for (int i = 0; i < Blocks.Length; i++) {
                 if (block == Blocks[i]) {
                     return Replacement;

fCraft/Drawing/Brushes/ReplaceBrushBrush.cs

@@ -112,9 +112,7 @@ public bool Begin(Player player, DrawOperation op) {
 
 
         public Block NextBlock(DrawOperation op) {
-            if (op == null)
-                throw new ArgumentNullException("op");
-            Block block = op.Map.GetBlock(op.Coords);
+            Block block = (Block)op.Map.Blocks[op.Map.Index(op.Coords)];
             if (block == Block) {
                 return Replacement.NextBlock(op);
             }

fCraft/Drawing/Brushes/ReplaceNotBrush.cs

@@ -74,9 +74,7 @@ public override IBrushFactory Factory {
 
 
         public override Block NextBlock(DrawOperation op) {
-            if (op == null)
-                throw new ArgumentNullException("op");
-            Block block = op.Map.GetBlock(op.Coords);
+            Block block = (Block)op.Map.Blocks[op.Map.Index(op.Coords)];
             for (int i = 0; i < Blocks.Length; i++) {
                 if (block == Blocks[i]) {
                     return Block.None;