Log execution time of tasks in /taskdebug, use actual methods instead of delegates for some tasks for more cleaner list in /taskdebug

Author: UnknownShadow200

fCraft/Portals/PortalDB.cs

@@ -94,8 +94,9 @@ public static void Load() {
             }
         }
 
+        static void SaveCallback( SchedulerTask task ) { Save(); }
         public static void StartSaveTask() {
-            SchedulerTask saveTask = Scheduler.NewBackgroundTask(delegate { Save(); }).RunForever(SaveInterval, SaveInterval + TimeSpan.FromSeconds(15));
+            Scheduler.NewBackgroundTask( SaveCallback ).RunForever(SaveInterval, SaveInterval + TimeSpan.FromSeconds(15));
         }
     }
 }

fCraft/System/Scheduler.cs

@@ -69,8 +69,8 @@ static void MainLoop() {
                         }
                     } else {
                         task.IsExecuting = true;
-#if DEBUG_SCHEDULER
                         task.ExecuteStart = DateTime.UtcNow;
+#if DEBUG_SCHEDULER
                         FireEvent( TaskExecuting, task );
 #endif
 
@@ -87,8 +87,8 @@ static void MainLoop() {
                         }
 #endif
 
-#if DEBUG_SCHEDULER
                         task.ExecuteEnd = DateTime.UtcNow;
+#if DEBUG_SCHEDULER
                         FireEvent( TaskExecuted, task );
 #endif
                     }
@@ -289,10 +289,6 @@ public static void PrintTasks( [NotNull] Player player ) {
             lock( TaskListLock ) {
                 foreach( SchedulerTask task in Tasks ) {
                     player.Message( task.ToString() );
-#if DEBUG_SCHEDULER
-                    TimeSpan delta = task.ExecuteEnd - task.ExecuteStart;
-                    player.Message( "   Exceution time: {0} milliseconds", delta.TotalMilliseconds);
-#endif
                 }
             }
         }

fCraft/System/SchedulerTask.cs

@@ -79,9 +79,9 @@ internal SchedulerTask( [NotNull] SchedulerCallback callback, bool isBackground,
         /// can be used for anything you want. </summary>
         public object UserState { get; set; }
 
-#if DEBUG_SCHEDULER
         public DateTime ExecuteStart, ExecuteEnd;
-#endif
+
+        
         #region Run Once
 
         /// <summary> Runs the task once, as quickly as possible.
@@ -263,7 +263,11 @@ public override string ToString() {
                 sb.Append( " -> " );
                 sb.Append( UserState );
             }
-            sb.Append( ')' );
+            
+            sb.Append( ") - (took " );
+            TimeSpan delta = ExecuteEnd - ExecuteStart;
+            sb.Append( delta.TotalMilliseconds );
+            sb.Append( " ms)" );
             return sb.ToString();
         }
     }

fCraft/System/Server.cs

@@ -420,7 +420,7 @@ public static bool StartServer() {
                 Scheduler.NewTask( ShowRandomAnnouncement ).RunForever( announcementInterval );
             }
             if (ConfigKey.IRCBotEnabled.Enabled() || ConfigKey.IRCBotChannels.GetString().Length >= 1 || ConfigKey.IRCBotNetwork.GetString().Length >= 1) {
-                Scheduler.NewTask(t => IRC.SendRawMessage(IRCCommands.Ping(ConfigKey.IRCBotChannels.GetString()), "", "")).RunForever(TimeSpan.FromMinutes(15));
+                Scheduler.NewTask( SendIrcPing ).RunForever( TimeSpan.FromMinutes( 15 ) );
             }
 
             ChatTimer.LoadAll();
@@ -1003,7 +1003,11 @@ static void MonitorProcessorUsage( SchedulerTask task ) {
             oldCPUTime = newCPUTime;
             IsMonitoringCPUUsage = true;
         }
+        
 
+        static void SendIrcPing( SchedulerTask task ) {
+            IRC.SendRawMessage(IRCCommands.Ping(ConfigKey.IRCBotChannels.GetString()), "", "");
+        }
         #endregion