Skip to content

Commit 870e484

Browse files
committed
Shut up a few CS1573 warnings
Also testing irc bot feature
1 parent ea44be1 commit 870e484

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

.travis.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@ solution: ProCraft.sln
33
notifications:
44
slack:
55
on_success: change
6+
irc:
7+
channels:
8+
- "irc.esper.net#ProCraft"
9+
on_success: change
610
script:
711
- loc_=/home/travis/build/123DMWM/ProCraft/bin/Release/
812
- ploc_=/home/travis/build/123DMWM/ProCraft/

fCraft/Network/Packet.cs

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ public Packet( [NotNull] byte[] rawBytes ) {
4545
/// <param name="player"> Player to whom this packet is being sent.
4646
/// Used to determine DeleteAdmincrete permission, for client-side checks. May not be null. </param>
4747
/// <param name="motd"> Message-of-the-day (text displayed below the server name). May not be null. </param>
48+
/// <param name="hasCP437"> If packet contains characters from CodePage 437 </param>
4849
/// <exception cref="ArgumentNullException"> player, serverName, or motd is null </exception>
4950
public static Packet MakeHandshake( [NotNull] Player player, [NotNull] string serverName, [NotNull] string motd, bool hasCP437 ) {
5051
if( serverName == null ) throw new ArgumentNullException( "serverName" );
@@ -78,6 +79,8 @@ public static Packet MakeSetBlock( Vector3I coords, Block type ) {
7879
/// <param name="id"> Entity ID. Negative values refer to "self". </param>
7980
/// <param name="name"> Entity name. May not be null. </param>
8081
/// <param name="spawn"> Spawning position for the player. </param>
82+
/// <param name="hasCP437"> If packet contains characters from CodePage 437 </param>
83+
/// <param name="extPos"> If player supports Extended Positions </param>
8184
/// <exception cref="ArgumentNullException"> name is null </exception>
8285
public static Packet MakeAddEntity( sbyte id, [NotNull] string name, Position spawn,
8386
bool hasCP437, bool extPos ) {
@@ -100,6 +103,7 @@ public static Packet MakeAddEntity( sbyte id, [NotNull] string name, Position sp
100103
/// <summary> Creates a new Teleport (0x08) packet. </summary>
101104
/// <param name="id"> Entity ID. Negative values refer to "self". </param>
102105
/// <param name="newPosition"> Position to teleport the entity to. </param>
106+
/// <param name="extPos"> If player supports Extended Positions </param>
103107
public static Packet MakeTeleport( sbyte id, Position newPosition, bool extPos ) {
104108
int size = PacketSizes[(byte)OpCode.Teleport];
105109
if (extPos) size += 6;
@@ -116,6 +120,7 @@ public static Packet MakeTeleport( sbyte id, Position newPosition, bool extPos )
116120

117121
/// <summary> Creates a new Teleport (0x08) packet, and sets ID to -1 ("self"). </summary>
118122
/// <param name="newPosition"> Position to teleport player to. </param>
123+
/// <param name="extPos"> If player supports Extended Positions </param>
119124
public static Packet MakeSelfTeleport( Position newPosition, bool extPos ) {
120125
return MakeTeleport( -1, newPosition.GetFixed(), extPos );
121126
}
@@ -178,6 +183,7 @@ public static Packet MakeRemoveEntity( sbyte id ) {
178183
/// <param name="type"> Message type. </param>
179184
/// <param name="message"> Message. </param>
180185
/// <param name="useFallbacks"> whether or not to use color fallback codes. </param>
186+
/// <param name="hasCP437"> If packet contains characters from CodePage 437 </param>
181187
public static Packet Message(byte type, string message, bool useFallbacks, bool hasCP437) {
182188
Packet packet = new Packet(OpCode.Message);
183189
packet.Bytes[1] = type;
@@ -193,6 +199,7 @@ public static Packet Message(byte type, string message, Player player) {
193199

194200
/// <summary> Creates a new Kick (0x0E) packet. </summary>
195201
/// <param name="reason"> Given reason. Only first 64 characters will be sent. May not be null. </param>
202+
/// <param name="hasCP437"> If packet contains characters from CodePage 437 </param>
196203
/// <exception cref="ArgumentNullException"> reason is null </exception>
197204
public static Packet MakeKick( [NotNull] string reason, bool hasCP437 ) {
198205
if( reason == null ) throw new ArgumentNullException( "reason" );

0 commit comments

Comments
 (0)