added ability to override default css and js folders #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…file check, json lookup tables
1602
added a commit
that referenced
this pull request
Jun 27, 2011
added ability to override default css and js folders
| @@ -5,10 +5,11 @@ app.configure(function(){ | |||
| app.use(express.static(cwd + '/public', {maxAge: 86400000})); | |||
| app.set('views', cwd + '/app/views'); | |||
| app.set('view engine', 'VIEWENGINE'); | |||
| app.set('jsDirectory', '/javascripts/'); | |||
There was a problem hiding this comment.
ExpressJS style requires human-readable settings names, AFAIK, for example: view engine, view cache. Maybe better to use words separated with spaces instead of camelCase?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another one i forgot to add previously. seems to work fine on my local copy. it caches the css and js files to their respective, overridden folders. I left it set to "/stylesheets/" and "/javascripts/" for default build purposes though. i currently have mine set to "/css/" and "/js/".
oh and i did realize how to make it so that only minimal commits would come through now =)
dale