Fixed a scope issue with the toObject method when printing all enumerable properties #321

Merged
merged 2 commits into from Nov 16, 2013

Conversation

Projects
None yet
3 participants
Contributor

making3 commented Sep 9, 2013

Replaces this[attr] with self[attr] in toObject for enumerable properties inside of the model.js library.

Contributor

absynce commented Nov 15, 2013

@1602, is there an issue with this to prevent it from being merged?

Owner

1602 commented Nov 16, 2013

@absynce thanks for pointing it out. merged.

@1602 1602 closed this Nov 16, 2013

@1602 1602 reopened this Nov 16, 2013

@1602 1602 merged commit 5e8f317 into 1602:master Nov 16, 2013

Owner

1602 commented Nov 16, 2013

Actually it was already implemented by another commit with correct version update. BTW, pull request should not update version.

Contributor

making3 commented Nov 18, 2013

@1602, I understand, I don't plan on updating the version with the pull request (if I make another request, I'll try to exclude it, or make a separate branch that has the version updated). It's typically updated on our end so we can use a temporary version of the package with npm in our project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment